Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated scipy.integrate.cumtrapz with cumulative_trapezoid #2545

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

natsukium
Copy link
Contributor

scipy.integrate.cumulative_trapezoid was introduced in scipy 1.6.0 and scipy.integrate.cumtrapz was removed in scipy 1.14.0

https://scipy.github.io/devdocs/release/1.6.0-notes.html#scipy-integrate-improvements https://scipy.github.io/devdocs/release/1.14.0-notes.html#expired-deprecations

This PR will replace an obsolete method and allow us to keep up with the latest scipy.
Compatibility with scipy<1.6.0 will be lost, but I don't think it will be a problem even if we use python 3.8.

Copy link
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Balandat Balandat merged commit d95be0a into cornellius-gp:develop Jul 5, 2024
7 checks passed
@natsukium natsukium deleted the fix/deprecated-cumtrapz branch July 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants